Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Annotate correct type hints in AbstractTemplateView (#986) #987

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

s2b
Copy link
Contributor

@s2b s2b commented Aug 22, 2024

Partials and sections can (of course) return anything, as can any template.

Partials and sections can (of course) return anything, as can any
template.
@s2b
Copy link
Contributor Author

s2b commented Aug 22, 2024

before we merge, we should test this against TYPO3 Core Nightly

@s2b
Copy link
Contributor Author

s2b commented Aug 24, 2024

Core CI is green: https://git.typo3.org/typo3/CI/cms/-/pipelines/64132
Consequences for nightly-only are unlikely in my opinion, as only phpstan interprets these comments.

@s2b s2b merged commit 8dcb96a into 2.15 Aug 24, 2024
10 checks passed
@s2b s2b deleted the backport branch August 24, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants